Fail closed when whisper prompt caps coerce bools to 1 - #144
Merged
Conversation
Timing enrichment already type-checks max_whisper_segment_text_chars. The count caps still used int(... or 0), so true became 1 and truncated the word stream the scene-spec LLM uses for wait_word. Co-authored-by: jmjava <jmjava@gmail.com>
ruff green; pytest 804 passed, 1 skipped; docgen benchmark meets baseline. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 8, 2026 00:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Config.from_yamlalready requires YAML numbers for whisper prompt caps (#117). Timing enrichment type-checksmax_whisper_segment_text_chars(#122). The two count caps still did:boolis a subclass ofint:max_whisper_words_in_prompt: truebecame 1 and truncated the word stream the scene-spec LLM uses forwait_word. Quoted"12"became 12 instead of raising.Called out as out of scope of #142.
Change
_nonneg_yaml_intfor segments / words / chars capsSceneGenerationError0still lists every wordGate
ruff check src/ tests/greenpytest tests/— 804 passed, 1 skippeddocgen benchmarkmeetssrc/docgen/benchmark_data/baseline.json(no clock change; no--update-baseline)Out of scope
Config.from_yamlalready gates these keys for CLI load_check_streams/_check_driftffprobereturncodestart/endfloat(... or 0.0)inai_clientMilestone:
milestones/whisper-prompt-caps.md